Feat add calculate consumed water#82
Merged
Merged
Conversation
bruno-f-cruz
requested changes
May 11, 2026
Member
bruno-f-cruz
left a comment
bruno-f-cruz
left a comment
There was a problem hiding this comment.
What about manually delivered water? Does it count towards this tally?
Collaborator
Author
|
@bruno-f-cruz I added a GiveManualWaterRight subject in Operation control to use when users press the water button in the visualizer. Also added a GiveManualWaterRight software event to read from in the calculate water function. It feels like there could be a simpler way so lemme know |
Collaborator
Author
|
@bruno-f-cruz any chance you could look at this? It feels kinda hacky, I think we do need to log some how that there has been a manual water event that is not aligned to the go cue |
bruno-f-cruz
reviewed
Jun 5, 2026
bruno-f-cruz
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally added this to a metadata mapper pr. Want to push to main to be able to use in future brances